Chromium Code Reviews
DescriptionReland of Add isnan() workaround for Intel Mac (patchset #1 id:1 of https://codereview.chromium.org/2405773002/ )
Reason for revert:
Relanding the original CL - the test failed again, so this isn't the cause.
Original issue's description:
> Revert of Add isnan() workaround for Intel Mac (patchset #4 id:60001 of https://codereview.chromium.org/2376033004/ )
>
> Reason for revert:
> Seems to have broken NavigatingExtensionPopupBrowserTest.DownloadViaPost on Mac 10.10:
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8270
>
> Original issue's description:
> > Add isnan() workaround for Intel Mac
> >
> > On some Intel drivers (skylake Windows and Mac), calling
> > function isnan() on highp float will get wrong answer.
> > This patch work arounds this bug by using an expression
> > to emulate this GLSL function. Skylake device ids are
> > referenced from:
> > https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h
> >
> > BUG=650547
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/9358866a937bc8cb9facb7feb9d087fab355e459
> > Cr-Commit-Position: refs/heads/master@{#424101}
>
> TBR=qiankun.miao@intel.com,kbr@chromium.org,zmo@chromium.org,jiawei.shao@intel.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=650547
>
> Committed: https://crrev.com/7026791422f0046a47bb849b2f2dc3212aab8415
> Cr-Commit-Position: refs/heads/master@{#424121}
TBR=qiankun.miao@intel.com,kbr@chromium.org,zmo@chromium.org,jiawei.shao@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=650547
Committed: https://crrev.com/f8a8059eae91342af8c1e7e56e1519c86f0b94d7
Cr-Commit-Position: refs/heads/master@{#424138}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||