Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2404863002: Reland of Add isnan() workaround for Intel Mac (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add isnan() workaround for Intel Mac (patchset #1 id:1 of https://codereview.chromium.org/2405773002/ ) Reason for revert: Relanding the original CL - the test failed again, so this isn't the cause. Original issue's description: > Revert of Add isnan() workaround for Intel Mac (patchset #4 id:60001 of https://codereview.chromium.org/2376033004/ ) > > Reason for revert: > Seems to have broken NavigatingExtensionPopupBrowserTest.DownloadViaPost on Mac 10.10: > https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8270 > > Original issue's description: > > Add isnan() workaround for Intel Mac > > > > On some Intel drivers (skylake Windows and Mac), calling > > function isnan() on highp float will get wrong answer. > > This patch work arounds this bug by using an expression > > to emulate this GLSL function. Skylake device ids are > > referenced from: > > https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h > > > > BUG=650547 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/9358866a937bc8cb9facb7feb9d087fab355e459 > > Cr-Commit-Position: refs/heads/master@{#424101} > > TBR=qiankun.miao@intel.com,kbr@chromium.org,zmo@chromium.org,jiawei.shao@intel.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=650547 > > Committed: https://crrev.com/7026791422f0046a47bb849b2f2dc3212aab8415 > Cr-Commit-Position: refs/heads/master@{#424121} TBR=qiankun.miao@intel.com,kbr@chromium.org,zmo@chromium.org,jiawei.shao@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650547 Committed: https://crrev.com/f8a8059eae91342af8c1e7e56e1519c86f0b94d7 Cr-Commit-Position: refs/heads/master@{#424138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Reland of Add isnan() workaround for Intel Mac
4 years, 2 months ago (2016-10-10 13:10:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404863002/1
4 years, 2 months ago (2016-10-10 13:10:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 13:11:28 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 13:13:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a8059eae91342af8c1e7e56e1519c86f0b94d7
Cr-Commit-Position: refs/heads/master@{#424138}

Powered by Google App Engine
This is Rietveld 408576698