Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Issue 2404843002: X87: Reland "[turbofan] Discard the shared code entry in the optimized code map.". (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland "[turbofan] Discard the shared code entry in the optimized code map.". port ec132e05ec197e77b9ada8040eb5957cf4a753f5 (r40086) original commit message: (GcStress failure was unrelated.) At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. BUG= Committed: https://crrev.com/90ebb7b4dd9bcf296f25566fc003f899fd5c2721 Cr-Commit-Position: refs/heads/master@{#40147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/builtins/x87/builtins-x87.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL,thanks!
4 years, 2 months ago (2016-10-10 10:55:59 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-11 01:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404843002/1
4 years, 2 months ago (2016-10-11 02:14:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 02:38:19 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 02:38:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90ebb7b4dd9bcf296f25566fc003f899fd5c2721
Cr-Commit-Position: refs/heads/master@{#40147}

Powered by Google App Engine
This is Rietveld 408576698