sandbox/win/src/process_mitigations_test.cc - Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/process_mitigations_test.cc

Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength. (Closed)

Patch Set: Fix error handling in POSIX version of the base::File::GetLength. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/process_mitigations_test.cc

diff --git a/sandbox/win/src/process_mitigations_test.cc b/sandbox/win/src/process_mitigations_test.cc

index 7aae5964bec3872ed1996b89398933de01eb1bae..53b0442c1c54d0cc0a0fad6d7672448f57bea114 100644

--- a/sandbox/win/src/process_mitigations_test.cc

+++ b/sandbox/win/src/process_mitigations_test.cc

@@ -1536,6 +1536,8 @@ SBOX_TESTS_COMMAND int CheckWin10FontLoad(int argc, wchar_t** argv) {

std::vector<char> font_data;

int64_t len = file.GetLength();

+ if (len < 0)

+ return SBOX_TEST_NOT_FOUND;

font_data.resize(len);

int read = file.Read(0, &font_data[0], len);