content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc - Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc

Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength. (Closed)

Patch Set: Fix error handling in POSIX version of the base::File::GetLength. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/core/browser/ruleset_service.cc ('k') | net/disk_cache/blockfile/file_ios.cc » ('j') | net/disk_cache/blockfile/mapped_file.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc

diff --git a/content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc b/content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc

index d2212ec3501ff32b1ad245c1eec5dc5b7cbddbf6..643fc3337471439750e1cfc7edd1a03ec99f2088 100644

--- a/content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc

+++ b/content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc

@@ -83,6 +83,7 @@ class AudioInputDebugWriterTest

// 0 4 "RIFF"

EXPECT_EQ(0, strncmp(wav_header, "RIFF", 4));

// 4 4 <file length - 8>

+ ASSERT_GT(file_length, 8);

EXPECT_EQ(static_cast<uint64_t>(file_length - 8), ReadLE4(wav_header + 4));

EXPECT_EQ(static_cast<uint32_t>(data_size + kWavHeaderSize - 8),

ReadLE4(wav_header + 4));