components/search_provider_logos/logo_cache_unittest.cc - Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_provider_logos/logo_cache_unittest.cc

Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength. (Closed)

Patch Set: Fix error handling in POSIX version of the base::File::GetLength. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_provider_logos/logo_cache_unittest.cc

diff --git a/components/search_provider_logos/logo_cache_unittest.cc b/components/search_provider_logos/logo_cache_unittest.cc

index 6a7dcbae646cab499c7794cc33658ff0b661e589..0de7e3897d329554f4f2a0ba0511346a10a761e7 100644

--- a/components/search_provider_logos/logo_cache_unittest.cc

+++ b/components/search_provider_logos/logo_cache_unittest.cc

@@ -94,7 +94,7 @@ void ExpectLogosEqual(const EncodedLogo& expected_logo,

void ShortenFile(base::FilePath path) {

base::File file(path, base::File::FLAG_OPEN | base::File::FLAG_WRITE);

int64_t file_length = file.GetLength();

- ASSERT_NE(file_length, 0);

+ ASSERT_GT(file_length, 0);

file.SetLength(file_length - 1);

}