base/files/file_posix.cc - Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_posix.cc

Issue 2404823002: Fix error handling in POSIX version of the base::File::GetLength. (Closed)

Patch Set: Fix error handling in POSIX version of the base::File::GetLength. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_posix.cc

diff --git a/base/files/file_posix.cc b/base/files/file_posix.cc

index a0f2328fe20be9f024c2a3cdc933cc0c6238b8b0..fcd190ac16f7561965f41d8ff3bec1d9ed3602e7 100644

--- a/base/files/file_posix.cc

+++ b/base/files/file_posix.cc

@@ -321,7 +321,7 @@ int64_t File::GetLength() {

stat_wrapper_t file_info;

if (CallFstat(file_.get(), &file_info))

- return false;

+ return -1;

return file_info.st_size;

}