Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: src/IceTargetLoweringMIPS32.h

Issue 2404803002: [Subzero][MIPS32] Implement bitcast operation for both 32-bit and 64-bit operands (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addressed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringMIPS32.h
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index 49cf2a2952d8aa9342b39df197c816830cb8d4be..842f266e2be730aced312e48437e56d3910393bb 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -341,15 +341,15 @@ public:
Context.insert<InstMIPS32Mflo>(Dest, Src);
}
- void _mov(Variable *Dest, Operand *Src0) {
+ void _mov(Variable *Dest, Operand *Src0, Operand *Src1 = nullptr) {
assert(Dest != nullptr);
// Variable* Src0_ = llvm::dyn_cast<Variable>(Src0);
if (llvm::isa<ConstantRelocatable>(Src0)) {
Context.insert<InstMIPS32La>(Dest, Src0);
} else {
- auto *Instr = Context.insert<InstMIPS32Mov>(Dest, Src0);
- if (Instr->isMultiDest()) {
- // If Instr is multi-dest, then Dest must be a Variable64On32. We add a
+ auto *Instr = Context.insert<InstMIPS32Mov>(Dest, Src0, Src1);
+ if (Instr->getDestHi() != nullptr) {
+ // If DestHi is available, then Dest must be a Variable64On32. We add a
// fake-def for Instr.DestHi here.
assert(llvm::isa<Variable64On32>(Dest));
Context.insert<InstFakeDef>(Instr->getDestHi());

Powered by Google App Engine
This is Rietveld 408576698