[Mac] Avoid "adding unknown subview" warning.

chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Index: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
index 0d1927f1bee471859e4aacc843fa6e9f524893ab..49bf202a705891f150af74a3a233dddafb75cc46 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
@@ -25,6 +25,14 @@
 // of non-layer backed content like the window controls.
 - (void)insertTabStripBackgroundViewIntoWindow:(NSWindow*)window
                                       titleBar:(BOOL)hasTitleBar;
+
+// Called when NSWindowWillEnterFullScreenNotification notification received.
+// Makes visual effects view hidden as it should not be displayed in fullscreen.
+- (void)windowWillEnterFullScreenNotification:(NSNotification*)notification;

[tapted, 2016/10/10 23:38:06]

nit: windowWillEnterFullScreen: (consistent with BrowserWindowController)

[Eugene But (OOO till 7-30), 2016/10/11 00:33:10]

|windowWillEnterFullScreen:| does not follow Coding Guidelines for Cocoa which
say "Make the word before the argument describe the argument.":
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Co...

Coding Guidelines for Cocoa is the basis for Google Objective-C Style Guide and
following style guide naming seems to be more important than being consistent
with another file (which does not follow naming rules strictly). WDYT?

+// Called when NSWindowWillExitFullScreenNotification notification received.

[tapted, 2016/10/10 23:38:06]

nit: blank line before [consistency]

[Eugene But (OOO till 7-30), 2016/10/11 00:33:10]

Done.

+// Makes visual effects view visible since it was hidden in fullscreen.
+- (void)windowWillExitFullScreenNotification:(NSNotification*)notification;
+
 @end
 
 @interface TabWindowOverlayWindow : NSWindow
@@ -89,12 +97,10 @@
     // the parent window so that it can be translucent, while the tab strip view
     // moves to the child window and stays opaque.
     NSView* windowView = [window contentView];
+    CGFloat paintHeight = [FramedBrowserWindow browserFrameViewPaintHeight];
     tabStripBackgroundView_.reset([[TabStripBackgroundView alloc]
-        initWithFrame:NSMakeRect(0,
-                                 NSMaxY([windowView bounds]) -
-                                     kBrowserFrameViewPaintHeight,
-                                 NSWidth([windowView bounds]),
-                                 kBrowserFrameViewPaintHeight)]);
+        initWithFrame:NSMakeRect(0, NSMaxY([windowView bounds]) - paintHeight,
+                                 NSWidth([windowView bounds]), paintHeight)]);
     [tabStripBackgroundView_
         setAutoresizingMask:NSViewWidthSizable | NSViewMinYMargin];
     [self insertTabStripBackgroundViewIntoWindow:window titleBar:hasTitleBar];
@@ -106,10 +112,28 @@
                                        NSViewMinYMargin];
     if (hasTabStrip)
       [windowView addSubview:tabStripView_];
+
+    if (chrome::ShouldUseFullSizeContentView()) {
+      [[NSNotificationCenter defaultCenter]
+          addObserver:self
+             selector:@selector(windowWillEnterFullScreenNotification:)
+                 name:NSWindowWillEnterFullScreenNotification
+               object:window];
+      [[NSNotificationCenter defaultCenter]
+          addObserver:self
+             selector:@selector(windowWillExitFullScreenNotification:)
+                 name:NSWindowWillExitFullScreenNotification
+               object:window];
+    }
   }
   return self;
 }
 
+- (void)dealloc {
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
+  [super dealloc];
+}
+
 - (NSView*)tabStripBackgroundView {
   return tabStripBackgroundView_;
 }
@@ -394,13 +418,18 @@
   [visualEffectView setBlendingMode:NSVisualEffectBlendingModeBehindWindow];
   [visualEffectView setState:NSVisualEffectStateFollowsWindowActiveState];
 
-  [rootView addSubview:visualEffectView
-            positioned:NSWindowBelow
-            relativeTo:nil];
+  if (chrome::ShouldUseFullSizeContentView()) {
+    [[window contentView] addSubview:visualEffectView];
+  } else {
+    [rootView addSubview:visualEffectView
+              positioned:NSWindowBelow
+              relativeTo:nil];
+  }
 
   // Make the |tabStripBackgroundView_| a child of the NSVisualEffectView.
   [tabStripBackgroundView_ setFrame:[visualEffectView bounds]];
   [visualEffectView addSubview:tabStripBackgroundView_];
+  visualEffectView_.reset([visualEffectView retain]);

[tapted, 2016/10/10 23:38:06]

since visualEffectView is also scoped_nsobject, we should just be able to assign
here. Although I'd probably just go with visualEffectView_.reset([[foo alloc]
initWith..]) up on line 399, and add an underscore to the stuff above

[Eugene But (OOO till 7-30), 2016/10/11 00:33:10]

Done.

 }
 
 // Called when the size of the window content area has changed. Override to
@@ -409,4 +438,12 @@
   NOTIMPLEMENTED();
 }
 
+- (void)windowWillEnterFullScreenNotification:(NSNotification*)notification {
+  [[visualEffectView_ animator] setAlphaValue:0.0];

[tapted, 2016/10/10 23:38:06]

I wonder if there are implications for text rendering / supbixel AA if we change
the opacity of this. E.g. do tab titles and the profile selector still look
right. (although at a glance, the profile selector is doing something to force
subpixel AA and it's getting the backgroudn colour wrong anyway)

[Eugene But (OOO till 7-30), 2016/10/11 00:33:10]

Visually looks the same before and after the changes.

+}
+
+- (void)windowWillExitFullScreenNotification:(NSNotification*)notification {
+  [[visualEffectView_ animator] setAlphaValue:1.0];

[tapted, 2016/10/10 23:38:06]

Maybe worth a note for these - visualEffectView_ will be nil for popups (i.e.
when hasTitleBar is false in insertTabStripBackgroundViewIntoWindow:) - the code
works, but it could be a trap for the unwary later

[Eugene But (OOO till 7-30), 2016/10/11 00:33:10]

Done. Added comments to the header.

+}
+
 @end