Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.h

Issue 2404783002: [Mac] Avoid "adding unknown subview" warning. (Closed)
Patch Set: Added comments to the code that adds fullscreen enter/exit observer Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_
7 7
8 // A class acting as the Objective-C window controller for a window that has 8 // A class acting as the Objective-C window controller for a window that has
9 // tabs which can be dragged around. Tabs can be re-arranged within the same 9 // tabs which can be dragged around. Tabs can be re-arranged within the same
10 // window or dragged into other TabWindowController windows. This class doesn't 10 // window or dragged into other TabWindowController windows. This class doesn't
11 // know anything about the actual tab implementation or model, as that is fairly 11 // know anything about the actual tab implementation or model, as that is fairly
12 // application-specific. It only provides an API to be overridden by subclasses 12 // application-specific. It only provides an API to be overridden by subclasses
13 // to fill in the details. 13 // to fill in the details.
14 14
15 #import <Cocoa/Cocoa.h> 15 #import <Cocoa/Cocoa.h>
16 16
17 #include "base/mac/scoped_nsobject.h" 17 #include "base/mac/scoped_nsobject.h"
18 18
19 @class FastResizeView; 19 @class FastResizeView;
20 @class FocusTracker; 20 @class FocusTracker;
21 @class NSVisualEffectView;
21 @class TabStripView; 22 @class TabStripView;
22 @class TabView; 23 @class TabView;
23 24
24 @interface TabWindowController : NSWindowController<NSWindowDelegate> { 25 @interface TabWindowController : NSWindowController<NSWindowDelegate> {
25 @private 26 @private
26 // Wrapper view around web content, and the developer tools view. 27 // Wrapper view around web content, and the developer tools view.
27 base::scoped_nsobject<FastResizeView> tabContentArea_; 28 base::scoped_nsobject<FastResizeView> tabContentArea_;
28 base::scoped_nsobject<NSView> tabStripBackgroundView_; 29 base::scoped_nsobject<NSView> tabStripBackgroundView_;
30 // Used to blur the titlebar. nil if window does not have titlebar.
tapted 2016/10/11 04:21:43 nit: blank line before
Eugene But (OOO till 7-30) 2016/10/11 04:35:46 Done.
31 base::scoped_nsobject<NSVisualEffectView> visualEffectView_;
29 32
30 // The tab strip overlaps the titlebar of the window. 33 // The tab strip overlaps the titlebar of the window.
31 base::scoped_nsobject<TabStripView> tabStripView_; 34 base::scoped_nsobject<TabStripView> tabStripView_;
32 35
33 // No views should be added directly to the root view. Views that overlap 36 // No views should be added directly to the root view. Views that overlap
34 // the title bar should be added to the window's contentView. All other views 37 // the title bar should be added to the window's contentView. All other views
35 // should be added to chromeContentView_. This allows tab dragging and 38 // should be added to chromeContentView_. This allows tab dragging and
36 // fullscreen logic to easily move the views that don't need special 39 // fullscreen logic to easily move the views that don't need special
37 // treatment. 40 // treatment.
38 base::scoped_nsobject<NSView> chromeContentView_; 41 base::scoped_nsobject<NSView> chromeContentView_;
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // Tells the tab strip to forget about this tab in preparation for it being 176 // Tells the tab strip to forget about this tab in preparation for it being
174 // put into a different tab strip, such as during a drop on another window. 177 // put into a different tab strip, such as during a drop on another window.
175 - (void)detachTabView:(NSView*)view; 178 - (void)detachTabView:(NSView*)view;
176 179
177 // Called when the size of the window content area has changed. Override to 180 // Called when the size of the window content area has changed. Override to
178 // position specific views. Base class implementation does nothing. 181 // position specific views. Base class implementation does nothing.
179 - (void)layoutSubviews; 182 - (void)layoutSubviews;
180 @end 183 @end
181 184
182 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_ 185 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_WINDOW_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_view.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698