third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2404743002: Web Audio: record autoplay status when an AudioContext is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2404743002: Web Audio: record autoplay status when an AudioContext is destroyed. (Closed)

Patch Set: move recording Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index b675a8d5ee2a604f5f028f7290983fffc19d685b..4826d3d94a1882b634c2de9b62f0dfd474813094 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -499,8 +499,7 @@ void AudioBufferSourceHandler::startSource(double when,

ExceptionState& exceptionState) {

DCHECK(isMainThread());

- // TODO(mlamouri): record when this is called with a user gesture and could

- // have started the AudioContext if following Safari iOS rules.

+ context()->maybeRecordStartAttempt();

if (playbackState() != UNSCHEDULED_STATE) {

exceptionState.throwDOMException(InvalidStateError,