Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 240473003: Ability to force position-independent code generation. (Closed)

Created:
6 years, 8 months ago by hoho
Modified:
6 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Ability to force position-independent code generation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/toolchain.gypi View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hoho
The CQ bit was checked by dakota@brokenpipe.ru
6 years, 8 months ago (2014-04-16 18:00:03 UTC) #1
hoho
The CQ bit was unchecked by dakota@brokenpipe.ru
6 years, 8 months ago (2014-04-16 18:00:04 UTC) #2
hoho
The CQ bit was checked by dakota@brokenpipe.ru
6 years, 8 months ago (2014-04-16 18:10:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 18:15:15 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 8 months ago (2014-04-16 18:15:15 UTC) #5
hoho
My motivation and discussion of this change is starting from this comment: https://groups.google.com/d/msg/v8-users/1vva9qjvstE/JV12NDOvumAJ
6 years, 8 months ago (2014-04-22 11:37:24 UTC) #6
danno
Please follow the V8 external committer process. Among other things, neither is your base URL ...
6 years, 8 months ago (2014-04-22 12:46:22 UTC) #7
hoho
I tried to start with these instructions. The problem is they refer to http://dev.chromium.org/developers/contributing-code and ...
6 years, 8 months ago (2014-04-22 13:08:26 UTC) #8
hoho
6 years, 8 months ago (2014-04-22 14:00:26 UTC) #9
I've resubmitted this from svn: https://codereview.chromium.org/247453002/
Please note that Github wiki page is really confusing.

Powered by Google App Engine
This is Rietveld 408576698