Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2404703002: Fix more tests under windows (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-08 21:57:39 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-08 21:58:58 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-09 15:45:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cce23d60b0236a1606a3d318fe81eeb796cb98ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698