Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2404673002: [wasm] Avoid copying when deserializing wasm (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Avoid copying when deserializing wasm Updated the deserialization API to avoid copying uncompiled bytes. BUG= Committed: https://crrev.com/cc02e74320c940902d7004ec070587289c04d8da Cr-Commit-Position: refs/heads/master@{#40108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M include/v8.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Mircea Trofin
4 years, 2 months ago (2016-10-08 16:14:24 UTC) #7
bradnelson
lgtm It looks like this part of the API hasn't been hooked up in chrome ...
4 years, 2 months ago (2016-10-10 03:35:05 UTC) #8
Mircea Trofin
On 2016/10/10 03:35:05, bradnelson wrote: > lgtm > > It looks like this part of ...
4 years, 2 months ago (2016-10-10 03:38:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404673002/1
4 years, 2 months ago (2016-10-10 03:38:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 04:12:34 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 04:12:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc02e74320c940902d7004ec070587289c04d8da
Cr-Commit-Position: refs/heads/master@{#40108}

Powered by Google App Engine
This is Rietveld 408576698