Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2404663002: DevTools: Do not allow v8 to use inspector. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
dgozman, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

DevTools: Do not allow v8 to use inspector. Committed: https://crrev.com/f116876e9175475590c61fc0c29c95370fdf9157 Cr-Commit-Position: refs/heads/master@{#40237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
alph
4 years, 2 months ago (2016-10-08 02:06:02 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-10-10 18:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404663002/1
4 years, 2 months ago (2016-10-11 17:22:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26179)
4 years, 2 months ago (2016-10-11 17:26:24 UTC) #7
alph
Yang, could you please take a look.
4 years, 2 months ago (2016-10-12 00:00:49 UTC) #9
Yang
On 2016/10/12 00:00:49, alph wrote: > Yang, could you please take a look. lgtm
4 years, 2 months ago (2016-10-12 04:45:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404663002/1
4 years, 2 months ago (2016-10-12 19:01:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 19:24:48 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:25:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f116876e9175475590c61fc0c29c95370fdf9157
Cr-Commit-Position: refs/heads/master@{#40237}

Powered by Google App Engine
This is Rietveld 408576698