device/bluetooth/public/interfaces/device.mojom - Issue 2404623002: bluetooth: Add DeviceChanged logging in Device service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/public/interfaces/device.mojom

Issue 2404623002: bluetooth: Add DeviceChanged logging in Device service. (Closed)

Patch Set: Remove proxy from Device in JS Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module bluetooth.mojom;	5 module bluetooth.mojom;

6	6

	7 // TODO(crbug.com/657632): Remove when numerical values can be optional.

	8 struct RSSIWrapper {
	ortuno 2016/10/19 23:19:19 I wish we had an Optional<> in javascript :/ I wish we had an Optional<> in javascript :/ mbrunson 2016/10/20 00:33:51 Yeah... I think that's planned for ES8. I think th Show quoted text On 2016/10/19 23:19:19, ortuno wrote: > I wish we had an Optional<> in javascript :/ Yeah... I think that's planned for ES8. I think the closest we get now is overloading valueOf or toString mixed with funky getters and setters...eww.
	9 int8 value;

	10 };

	11

7 struct DeviceInfo {	12 struct DeviceInfo {

8 string? name;	13 string? name;

9 string name_for_display;	14 string name_for_display;

10 string address;	15 string address;

	16 RSSIWrapper? rssi;

11 };	17 };

12	18

13 interface Device {	19 interface Device {

14 // Gets basic information about the device. Returns null, if no device is	20 // Gets basic information about the device. Returns null, if no device is

15 // available.	21 // available.

16 GetInfo() => (DeviceInfo? info);	22 GetInfo() => (DeviceInfo? info);

17 };	23 };

OLD	NEW