device/bluetooth/public/interfaces/device.mojom - Issue 2404623002: bluetooth: Add DeviceChanged logging in Device service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/public/interfaces/device.mojom

Issue 2404623002: bluetooth: Add DeviceChanged logging in Device service. (Closed)

Patch Set: Change PacketReceived to DeviceChanged Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module bluetooth.mojom;	5 module bluetooth.mojom;

6	6

7 struct DeviceInfo {	7 struct DeviceInfo {

8 string? name;	8 string? name;

9 string name_for_display;	9 string name_for_display;

10 string address;	10 string address;

	11 int8 rssi;
	scheib 2016/10/19 21:28:56 I'd prefer we not use magic values to indicate the I'd prefer we not use magic values to indicate the value isn't there. Sounds like we can't use int8? rssi, and we discussed in meeting filing a bug on mojo and working around this and leaving TODOs by having an optional struct, e.g. struct RSSIWrapper { int8 value; } and then in DeviceInfo { RSSIWrapper? rssi; }. Does that work? mbrunson 2016/10/19 22:29:22 Done. Show quoted text On 2016/10/19 21:28:56, scheib wrote: > I'd prefer we not use magic values to indicate the value isn't there. Sounds > like we can't use int8? rssi, and we discussed in meeting filing a bug on mojo > and working around this and leaving TODOs by having an optional struct, e.g. > > struct RSSIWrapper { int8 value; } > > and then in DeviceInfo { RSSIWrapper? rssi; }. > > Does that work? Done.
11 };	12 };

12	13

13 interface Device {	14 interface Device {

14 // Gets basic information about the device. Returns null, if no device is	15 // Gets basic information about the device. Returns null, if no device is

15 // available.	16 // available.

16 GetInfo() => (DeviceInfo? info);	17 GetInfo() => (DeviceInfo? info);

17 };	18 };

OLD	NEW

« no previous file with comments | « device/bluetooth/public/interfaces/adapter.mojom ('k') | no next file » | no next file with comments »