Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2404593002: Don't access owning pointers after they've relinquished ownership. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't access owning pointers after they've relinquished ownership. BUG=653907 TEST=as in bug Committed: https://crrev.com/b350dc8a066204011fe8a6068f9ac6a73e932e6e Cr-Commit-Position: refs/heads/master@{#424337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/search_engines/util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Avi (use Gerrit)
Sigh.
4 years, 2 months ago (2016-10-07 23:10:01 UTC) #6
Peter Kasting
LGTM
4 years, 2 months ago (2016-10-10 20:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404593002/1
4 years, 2 months ago (2016-10-11 00:48:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 01:48:39 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:50:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b350dc8a066204011fe8a6068f9ac6a73e932e6e
Cr-Commit-Position: refs/heads/master@{#424337}

Powered by Google App Engine
This is Rietveld 408576698