Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2404533002: DevTools: render element tree hover as a block. (Closed)

Created:
4 years, 2 months ago by pfeldman
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: render element tree hover as a block. Committed: https://crrev.com/397f5d56c49c89fec520dbd37bd09880d5c68e42 Cr-Commit-Position: refs/heads/master@{#424062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
pfeldman
4 years, 2 months ago (2016-10-07 20:57:42 UTC) #2
dgozman
Does this fix a bug? Screenshot?
4 years, 2 months ago (2016-10-07 21:43:56 UTC) #3
dgozman
lgtm
4 years, 2 months ago (2016-10-07 22:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404533002/1
4 years, 2 months ago (2016-10-08 01:05:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 04:21:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/397f5d56c49c89fec520dbd37bd09880d5c68e42 Cr-Commit-Position: refs/heads/master@{#424062}
4 years, 2 months ago (2016-10-08 04:24:08 UTC) #9
lushnikov
4 years, 2 months ago (2016-10-11 19:11:27 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2409293003/ by lushnikov@chromium.org.

The reason for reverting is: This broke elements panel hovering.
crbug.com/654702.

Powered by Google App Engine
This is Rietveld 408576698