Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 240453008: Update DesktopScreenX11::displays_ when the display layout changes (Closed)

Created:
6 years, 8 months ago by pkotwicz
Modified:
6 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Update |DesktopScreenX11::displays_| when the position of the monitor's content changes but the output MODE in use does not change. An example is switching whether the primary monitor is left of the secondary monitor. BUG=363482 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264648

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
pkotwicz
Elliot, PTAL
6 years, 8 months ago (2014-04-17 02:43:33 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/240453008/diff/1/ui/views/widget/desktop_aura/desktop_screen_x11.cc File ui/views/widget/desktop_aura/desktop_screen_x11.cc (right): https://codereview.chromium.org/240453008/diff/1/ui/views/widget/desktop_aura/desktop_screen_x11.cc#newcode322 ui/views/widget/desktop_aura/desktop_screen_x11.cc:322: } else if (event->type - xrandr_event_base_ == RRNotify) ...
6 years, 8 months ago (2014-04-17 17:40:52 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 8 months ago (2014-04-17 18:36:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/240453008/1
6 years, 8 months ago (2014-04-17 18:36:41 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 21:42:13 UTC) #5
Message was sent while issue was closed.
Change committed as 264648

Powered by Google App Engine
This is Rietveld 408576698