Fix sign-in error strings.

chrome/browser/ui/views/profiles/new_avatar_button.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/new_avatar_button.h"
 
 #include "base/win/windows_version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profiles_state.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/ui/browser.h"
+#include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/views/border.h"
 #include "ui/views/painter.h"
@@ skipping 70 matching lines @@
     const int kNormalImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_NORMAL);
     const int kHotImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_HOVER);
     const int kPushedImageSet[] = IMAGE_GRID(IDR_AVATAR_GLASS_BUTTON_PRESSED);
 
     SetBorder(CreateBorder(kNormalImageSet, kHotImageSet, kPushedImageSet));
     set_menu_marker(
         rb->GetImageNamed(IDR_AVATAR_GLASS_BUTTON_DROPARROW).ToImageSkia());
   }
 
   g_browser_process->profile_manager()->GetProfileInfoCache().AddObserver(this);
+
+  // Subscribe to authentication error changes so that the avatar button
+  // can update itself.
+  SigninErrorController* error =
+      ProfileOAuth2TokenServiceFactory::GetForProfile(browser_->profile())->
+          signin_error_controller();
+  error->AddObserver(this);
+  OnErrorChanged();
+
   SchedulePaint();
 }
 
 NewAvatarButton::~NewAvatarButton() {
   g_browser_process->profile_manager()->
       GetProfileInfoCache().RemoveObserver(this);
+  SigninErrorController* error =
+      ProfileOAuth2TokenServiceFactory::GetForProfile(browser_->profile())->
+          signin_error_controller();
+  error->RemoveObserver(this);
 }
 
-void NewAvatarButton::OnPaint(gfx::Canvas* canvas) {
-  // From TextButton::PaintButton, draw everything but the text.
-  OnPaintBackground(canvas);
-  OnPaintBorder(canvas);
-  views::Painter::PaintFocusPainter(this, canvas, focus_painter());
-
+void NewAvatarButton::OnPaintText(gfx::Canvas* canvas, PaintButtonMode mode) {
   gfx::Rect rect;
   // In RTL languages the marker gets drawn leftmost, so account for its offset.
   if (base::i18n::IsRTL())
     rect = gfx::Rect(-kInset, 0, size().width(), size().height());
   else
     rect = gfx::Rect(kInset, 0, size().width(), size().height());
 
   canvas->DrawStringRectWithHalo(
       text(),
       gfx::FontList(),
       SK_ColorWHITE,
       SK_ColorDKGRAY,
       rect,
       gfx::Canvas::NO_SUBPIXEL_RENDERING);
-
-  // From MenuButton::PaintButton, paint the marker
-  PaintMenuMarker(canvas);
 }
 
 void NewAvatarButton::OnProfileAdded(const base::FilePath& profile_path) {
   UpdateAvatarButtonAndRelayoutParent();
 }
 
 void NewAvatarButton::OnProfileWasRemoved(
       const base::FilePath& profile_path,
       const base::string16& profile_name) {
   UpdateAvatarButtonAndRelayoutParent();
 }
 
 void NewAvatarButton::OnProfileNameChanged(
       const base::FilePath& profile_path,
       const base::string16& old_profile_name) {
   UpdateAvatarButtonAndRelayoutParent();
 }
 
+void NewAvatarButton::OnErrorChanged() {
+  gfx::ImageSkia icon;
+
+  // If there is an error, use a special background.

[noms (inactive), 2014/05/11 19:21:25]

nit: I think the comment is wrong. You're only changing the menu marker, not the
background.

[Roger Tawa OOO till Jul 10th, 2014/05/13 21:23:54]

Done.

+  SigninErrorController* error =
+      ProfileOAuth2TokenServiceFactory::GetForProfile(browser_->profile())->
+          signin_error_controller();
+  if (error->HasError()) {
+    ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
+    icon = *rb->GetImageNamed(IDR_WARNING).ToImageSkia();
+  }
+
+  SetIcon(icon);
+}
+
 void NewAvatarButton::UpdateAvatarButtonAndRelayoutParent() {
   // We want the button to resize if the new text is shorter.
   ClearMaxTextSize();
   SetText(GetElidedText(
       profiles::GetAvatarNameForProfile(browser_->profile())));
 
   // Because the width of the button might have changed, the parent browser
   // frame needs to recalculate the button bounds and redraw it.
   parent()->Layout();
 }