predictors: Update the resource_prefetch_predictor db tool.

predictors: Update the resource_prefetch_predictor db tool.

The database format has changed, this updates the database visualization tool.

BUG=631966
Committed: https://crrev.com/a92016445f849baa7dbbfd70de72aaec9bb35086
Cr-Commit-Position: refs/heads/master@{#423871}

[Benoit L, 2016-10-07 13:44:38]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2016-10-07 13:55:25]

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
File tools/resource_prefetch_predictor/prefetch_predictor_tool.py (right):

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:29: def
_ComputeResourceScore(cls, resource):
Please mention the type of |resource| in the docstring here and in functions
below that have |resource| as paramater.

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:56: print resource
is the default python pretty-print looking good here? Perhaps pretty-print
manually? if you think that the default pretty-print is OK, please show it to
me, I am curious.

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:63:
resource.number_of_hits + resource.number_of_misses)
perhaps need to explicitly ask for a floating point result?

[Benoit L, 2016-10-07 14:03:10]

Thanks!

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
File tools/resource_prefetch_predictor/prefetch_predictor_tool.py (right):

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:29: def
_ComputeResourceScore(cls, resource):
On 2016/10/07 13:55:25, pasko wrote:
> Please mention the type of |resource| in the docstring here and in functions
> below that have |resource| as paramater.

Done.

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:56: print resource
On 2016/10/07 13:55:25, pasko wrote:
> is the default python pretty-print looking good here? Perhaps pretty-print
> manually? if you think that the default pretty-print is OK, please show it to
> me, I am curious.

Actually, protocol buffer are already pretty when using print, but I want to add
the score here (in the same style as the rest of the proto fields).


Example:

score: 12951
resource_url:
"http://s1.lemde.fr/medias/web/e669e9d9f3321b41fd54ccb1bad21cc3/js/lmd/module/retina.js"
resource_type: RESOURCE_TYPE_SCRIPT
number_of_hits: 3
consecutive_misses: 0
average_position: 49.0
priority: REQUEST_PRIORITY_LOWEST
has_validators: true
always_revalidate: false

https://codereview.chromium.org/2404453002/diff/1/tools/resource_prefetch_pre...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:63:
resource.number_of_hits + resource.number_of_misses)
On 2016/10/07 13:55:25, pasko wrote:
> perhaps need to explicitly ask for a floating point result?

/facepalm
Thanks!

Done.

[pasko, 2016-10-07 15:44:56]

thanks for parting the example

lgtm with 2 minor changes

https://codereview.chromium.org/2404453002/diff/20001/tools/resource_prefetch...
File tools/resource_prefetch_predictor/prefetch_predictor_tool.py (right):

https://codereview.chromium.org/2404453002/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:33: param:
ResourceData.
s/param/resource/

https://codereview.chromium.org/2404453002/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_predictor_tool.py:65: param:
ResourceData.
ditto

[Benoit L, 2016-10-07 16:01:36]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-10-07 16:01:36]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2404453002/#ps40001
(title: "...")

[commit-bot: I haz the power, 2016-10-07 16:02:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 16:10:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 16:13:17]

Description was changed from

==========
predictors: Update the resource_prefetch_predictor db tool.

The database format has changed, this updates the database visualization tool.

BUG=631966
==========

to

==========
predictors: Update the resource_prefetch_predictor db tool.

The database format has changed, this updates the database visualization tool.

BUG=631966

Committed: https://crrev.com/a92016445f849baa7dbbfd70de72aaec9bb35086
Cr-Commit-Position: refs/heads/master@{#423871}
==========

[commit-bot: I haz the power, 2016-10-07 16:13:18]

Patchset 3 (id:??) landed as
https://crrev.com/a92016445f849baa7dbbfd70de72aaec9bb35086
Cr-Commit-Position: refs/heads/master@{#423871}