Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: media/midi/midi_service.mojom

Issue 2404443002: Web MIDI: use midi_service.mojom for media::midi::Result (Closed)
Patch Set: fix layout test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_service.mojom
diff --git a/media/midi/midi_service.mojom b/media/midi/midi_service.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..ddac4a396621e54bba1e1ed6311a4b06832ab2a2
--- /dev/null
+++ b/media/midi/midi_service.mojom
@@ -0,0 +1,27 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module media.midi;
Reilly Grant (use Gerrit) 2016/10/11 17:57:57 Convention is to put mojo definitions into a names
Takashi Toyoshima 2016/10/12 05:01:44 Thanks. So, probably midi.mojom looks better rathe
+
+enum Result {
+ NOT_INITIALIZED,
+ OK,
+ NOT_SUPPORTED,
+ INITIALIZATION_ERROR,
+
+ // New code should be inserted here so that existing members keep the same
+ // assigned value. //tools/metrics/histograms/histograms.xml contains a enum
+ // entry that should be consistent with enum Result.
+
+ // |MAX| is used in content/common/media/midi_messages.h with
+ // IPC_ENUM_TRAITS_MAX_VALUE macro. Keep the value up to date. Otherwise
+ // a new value can not be passed to the renderer.
+ // TODO(toyoshim): Remove |MAX| once IPC is replaced with Mojo.
+ // http://crbug.com/582327
+ MAX = INITIALIZATION_ERROR,
+};
+
+// TODO(toyoshim): MidiPortState, MidiPortInfo, and MidiService should be
+// declared here.
+// http://crbug.com/582327

Powered by Google App Engine
This is Rietveld 408576698