Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: content/renderer/media/midi_message_filter.cc

Issue 2404443002: Web MIDI: use midi_service.mojom for media::midi::Result (Closed)
Patch Set: fix layout test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/midi_message_filter.cc
diff --git a/content/renderer/media/midi_message_filter.cc b/content/renderer/media/midi_message_filter.cc
index a9810ab40a90bad9fb2f7069e351bb2fb86e3063..177ef91b230e90b2023d77bc4014bffb7c4888c3 100644
--- a/content/renderer/media/midi_message_filter.cc
+++ b/content/renderer/media/midi_message_filter.cc
@@ -202,27 +202,6 @@ void MidiMessageFilter::OnAcknowledgeSentData(size_t bytes_sent) {
void MidiMessageFilter::HandleClientAdded(media::midi::Result result) {
TRACE_EVENT0("midi", "MidiMessageFilter::HandleClientAdded");
DCHECK(main_task_runner_->BelongsToCurrentThread());
- session_result_ = result;
- std::string error;
- std::string message;
- switch (result) {
- case media::midi::Result::OK:
- break;
- case media::midi::Result::NOT_SUPPORTED:
- error = "NotSupportedError";
- break;
- case media::midi::Result::INITIALIZATION_ERROR:
- error = "InvalidStateError";
- message = "Platform dependent initialization failed.";
- break;
- default:
- NOTREACHED();
- error = "InvalidStateError";
- message = "Unknown internal error occurred.";
- break;
- }
- base::string16 error16 = base::UTF8ToUTF16(error);
- base::string16 message16 = base::UTF8ToUTF16(message);
// A for-loop using iterators does not work because |client| may touch
// |clients_waiting_session_queue_| in callbacks.
@@ -249,8 +228,7 @@ void MidiMessageFilter::HandleClientAdded(media::midi::Result result) {
ToBlinkState(info.state));
}
}
- client->didStartSession(result == media::midi::Result::OK, error16,
- message16);
+ client->didStartSession(result);
clients_.insert(client);
}
}

Powered by Google App Engine
This is Rietveld 408576698