third_party/WebKit/public/platform/DEPS - Issue 2404443002: Web MIDI: use midi_service.mojom for media::midi::Result

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/DEPS

Issue 2404443002: Web MIDI: use midi_service.mojom for media::midi::Result (Closed)

Patch Set: fix layout test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« media/midi/midi_service.mojom ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIAccessorClient.h ('k') | third_party/WebKit/public/platform/modules/webmidi/WebMIDIAccessorClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base/callback_forward.h",	2 "+base/callback_forward.h",

3 "+base/location.h",	3 "+base/location.h",

4 "+base/logging.h",	4 "+base/logging.h",

5 "+base/metrics",	5 "+base/metrics",

6 "+base/trace_event",	6 "+base/trace_event",

7 "-bindings",	7 "-bindings",

8 "+cc",	8 "+cc",

9 "-cc/blink",	9 "-cc/blink",

10 "-core",	10 "-core",

11 "-modules",	11 "-modules",

	12 # TODO(toyoshim): Remove following media/midi direct dependency in public

	13 # interface once Web MIDI starts calling the Mojo service inside Blink.

	14 # http://crbug.com/582327

	15 "+media/midi/midi_service.mojom-shared.h",
	Reilly Grant (use Gerrit) 2016/10/11 17:57:57 The shared header shouldn't be included directly. The shared header shouldn't be included directly. Use midi_service.mojom-blink.h instead. Takashi Toyoshima 2016/10/12 05:01:44 WebMIDIAccessorClient.h includes this file, and it WebMIDIAccessorClient.h includes this file, and it provides a client interface that renderer_webmidiaccessor_impl implements in content. So, if I use -blink.h here, that results in including -blink.h indirectly from content. That results in compile error for failing including files from wtf/. What's a right approach here? Reilly Grant (use Gerrit) 2016/10/12 17:48:05 I checked with rockot@ and he says that including Show quoted text On 2016/10/12 at 05:01:44, toyoshim wrote: > WebMIDIAccessorClient.h includes this file, and it provides a client interface that renderer_webmidiaccessor_impl implements in content. > > So, if I use -blink.h here, that results in including -blink.h indirectly from content. That results in compile error for failing including files from wtf/. What's a right approach here? I checked with rockot@ and he says that including the mojom-shared.h file is the correct thing to do here. Sorry for the confusion.
12 "+mojo/public",	16 "+mojo/public",

13 "+platform",	17 "+platform",

14 "+platform/weborigin",	18 "+platform/weborigin",

15 "+public/platform",	19 "+public/platform",

16 "-public/web",	20 "-public/web",

17 "+third_party/skia",	21 "+third_party/skia",

18 "+url",	22 "+url",

19 "-web",	23 "-web",

20 ]	24 ]

OLD	NEW