Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 240443007: VM: Fix TypedefMirror.isPrivate and TypeVariableMirror.isPrivate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 9983abba1410f3288f11f6f7bb3cdefdbc63ff3d..0a7c2db2384bd59eb590b6f39a43e892133b1f43 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -958,6 +958,8 @@ abstract class _LocalDeclarationMirror extends _LocalMirror
return _qualifiedName;
}
+ bool get isPrivate => _n(simpleName).startsWith('_');
+
List<InstanceMirror> get metadata {
// Get the metadata objects, convert them into InstanceMirrors using
// reflect() and then make them into a Dart list.
@@ -987,7 +989,6 @@ class _LocalTypeVariableMirror extends _LocalDeclarationMirror
return _owner;
}
- bool get isPrivate => false;
bool get isStatic => false;
bool get isTopLevel => false;
@@ -1061,7 +1062,6 @@ class _LocalTypedefMirror extends _LocalDeclarationMirror
: super(reflectee, _s(simpleName));
bool get isTopLevel => true;
- bool get isPrivate => false;
DeclarationMirror _owner;
DeclarationMirror get owner {
@@ -1427,8 +1427,6 @@ class _LocalVariableMirror extends _LocalDeclarationMirror
this.isConst)
: super(reflectee, _s(simpleName));
- bool get isPrivate => _n(simpleName).startsWith('_');
-
bool get isTopLevel => owner is LibraryMirror;
SourceLocation get location {
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698