Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: ui/keyboard/keyboard_util.cc

Issue 240443006: Remove native VK window height logic and wait for resizeTo to setup VK window height (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_util.cc
diff --git a/ui/keyboard/keyboard_util.cc b/ui/keyboard/keyboard_util.cc
index 7048be2e5564f354b113df0185dbf009935c03ba..e345fd84e888cff796e40f58d93c8d902effa49b 100644
--- a/ui/keyboard/keyboard_util.cc
+++ b/ui/keyboard/keyboard_util.cc
@@ -46,21 +46,14 @@ base::LazyInstance<GURL> g_override_content_url = LAZY_INSTANCE_INITIALIZER;
// The ratio between the height of the keyboard and the screen when using the
// usability keyboard.
const float kUsabilityKeyboardHeightRatio = 1.0f;
+const float kInitialHeightRatio = 0.0f;
kevers 2014/04/22 17:45:23 Please add a comment. With the value now being 0
bshe 2014/04/23 01:08:53 Done.
-// The default ratio between the height of the keyboard and the screen.
-const float kDefaultKeyboardHeightRatio = 0.41f;
-
-// The ratio between the height of the keyboard and the screen when using the
-// accessibility keyboard.
-const float kAccessibilityKeyboardHeightRatio = 0.3f;
-
-float GetKeyboardHeightRatio(){
+float GetKeyboardHeightRatio() {
if (keyboard::IsKeyboardUsabilityExperimentEnabled()) {
return kUsabilityKeyboardHeightRatio;
- } else if (keyboard::GetAccessibilityKeyboardEnabled()) {
- return kAccessibilityKeyboardHeightRatio;
+ } else {
+ return kInitialHeightRatio;
}
- return kDefaultKeyboardHeightRatio;
}
bool g_touch_keyboard_enabled = false;
« ui/keyboard/keyboard_layout_manager.cc ('K') | « ui/keyboard/keyboard_layout_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698