Remove native VK window height logic and wait for resizeTo to setup VK window height

ash/wm/system_modal_container_layout_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/system_modal_container_layout_manager.h"
 
 #include "ash/root_window_controller.h"
 #include "ash/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 131 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(TransientWindowObserver);
 };
 
 }  // namespace
 
 class SystemModalContainerLayoutManagerTest : public AshTestBase {
  public:
   virtual void SetUp() OVERRIDE {
     // Allow a virtual keyboard (and initialize it per default).
-   CommandLine::ForCurrentProcess()->AppendSwitch(
-       keyboard::switches::kEnableVirtualKeyboard);
+    CommandLine::ForCurrentProcess()->AppendSwitch(
+        keyboard::switches::kEnableVirtualKeyboard);
     AshTestBase::SetUp();
     Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
         keyboard::KeyboardController::GetInstance());
   }
 
   virtual void TearDown() OVERRIDE {
     Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
         keyboard::KeyboardController::GetInstance());
     AshTestBase::TearDown();
   }
@@ skipping 16 matching lines @@
   void ShowKeyboard(bool show) {
     keyboard::KeyboardController* keyboard =
         keyboard::KeyboardController::GetInstance();
     ASSERT_TRUE(keyboard);
     if (show == keyboard->keyboard_visible())
       return;
 
     // The animation has to run in order to get the notification. Run the
     // animation and wait until its finished.
     ui::ScopedAnimationDurationScaleMode normal_duration_mode(
         ui::ScopedAnimationDurationScaleMode::NORMAL_DURATION);

[pkotwicz, 2014/04/23 15:18:42]

[Optional Nit]: You may be able to remove the need for enabling animations here.
Moving proxy_->ShowKeyboardContainer() in
KeyboardController::ShowKeyboardInternal() to the end of the function seems to
do the trick.

[bshe, 2014/04/23 16:07:12]

Done.

-    if (show)
-      keyboard->ShowAndLockKeyboard();
-    else
+    if (show) {
+      keyboard->ShowKeyboard(true);
+      if (keyboard->proxy()->GetKeyboardWindow()->bounds().height() == 0) {
+        gfx::Rect window_bounds = keyboard->GetContainerWindow()->bounds();
+        keyboard->proxy()->GetKeyboardWindow()->SetBounds(gfx::Rect(
+            window_bounds.x(),
+            window_bounds.y() + window_bounds.height() - 100,

[pkotwicz, 2014/04/23 15:18:42]

Nit: You can use window_bounds.bottom() here

[bshe, 2014/04/23 16:07:12]

Done.

+            window_bounds.width(),
+            100));
+      }
+    } else {
       keyboard->HideKeyboard(keyboard::KeyboardController::HIDE_REASON_MANUAL);
+    }
 
     WaitForWindowAnimationToBeFinished(keyboard->GetContainerWindow());
 
     DCHECK_EQ(show, keyboard->keyboard_visible());
   }
 
   void WaitForWindowAnimationToBeFinished(aura::Window* window) {
     DCHECK(window);
     ui::Layer* layer = window->layer();
     ui::LayerAnimatorTestController controller(layer->GetAnimator());
@@ skipping 375 matching lines @@
 
   // After the keyboard is gone, the window will remain where it was.
   ShowKeyboard(false);
   EXPECT_NE(modal_bounds.ToString(), modal_window->bounds().ToString());
   EXPECT_EQ(modal_size.ToString(), modal_window->bounds().size().ToString());
   EXPECT_EQ(modal_origin.x(), modal_window->bounds().x());
 }
 
 }  // namespace test
 }  // namespace ash