Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2404413003: Fix UnusedResoruces android lint warning in castshell_java (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
Simeon, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, ghost stip (do not use)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UnusedResoruces android lint warning in castshell_java It thought the app icon was unused because it wasn't being passed the AndroidManifest.xml BUG=623989 Committed: https://crrev.com/acd4e48ea65c9aad8bdc1fe3db7d529e4ddc5204 Cr-Commit-Position: refs/heads/master@{#424918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chromecast/browser/android/BUILD.gn View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
agrieve
🐾
4 years, 2 months ago (2016-10-12 19:05:52 UTC) #2
alokp
sanfin@: PTAL
4 years, 2 months ago (2016-10-12 19:58:32 UTC) #7
Simeon
On 2016/10/12 19:58:32, alokp wrote: > sanfin@: PTAL lgtm
4 years, 2 months ago (2016-10-12 21:08:27 UTC) #10
alokp
lgtm
4 years, 2 months ago (2016-10-12 23:08:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404413003/1
4 years, 2 months ago (2016-10-13 00:09:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 00:18:22 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 00:21:20 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acd4e48ea65c9aad8bdc1fe3db7d529e4ddc5204
Cr-Commit-Position: refs/heads/master@{#424918}

Powered by Google App Engine
This is Rietveld 408576698