Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 6a06e377bfc6ef12e09ece72292c01455913fcd9..f58086a5ba76ae935ab77a6f8d9e8504a2b76d09 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -1997,6 +1997,7 @@ TEST_P(ParameterizedVisualViewportTest, ResizeWithScrollAnchoring) {
FrameView& frameView = *webViewImpl()->mainFrameImpl()->frameView();
frameView.layoutViewportScrollableArea()->setScrollOffset(
ScrollOffset(700, 500), ProgrammaticScroll);
+ webViewImpl()->updateAllLifecyclePhases();
ymalik 2016/10/13 13:05:40 Why did we need to add this?
skobes 2016/10/13 17:21:37 The programmatic scroll clears the anchor node. I
ymalik 2016/10/13 17:53:19 Acknowledged.
webViewImpl()->resize(IntSize(800, 300));
EXPECT_SIZE_EQ(ScrollOffset(700, 200),

Powered by Google App Engine
This is Rietveld 408576698