Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout. (Closed)
Patch Set: add DCHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index 957be040ad0b49d213cc5de46cabd659900de7d3..e9597e14d4703f00d72f9b5c446f7785633387cd 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -399,7 +399,7 @@ void LayoutBlock::layout() {
bool needsScrollAnchoring =
hasOverflowClip() && getScrollableArea()->shouldPerformScrollAnchoring();
if (needsScrollAnchoring)
- getScrollableArea()->scrollAnchor()->save();
+ getScrollableArea()->scrollAnchor()->notifyBeforeLayout();
// Table cells call layoutBlock directly, so don't add any logic here. Put
// code into layoutBlock().
@@ -412,16 +412,6 @@ void LayoutBlock::layout() {
clearLayoutOverflow();
invalidateBackgroundObscurationStatus();
-
- // If clamping is delayed, we will restore in
- // PaintLayerScrollableArea::clampScrollPositionsAfterLayout.
- // Restoring during the intermediate layout may clamp the scroller to the
- // wrong bounds.
- bool clampingDelayed = PaintLayerScrollableArea::DelayScrollOffsetClampScope::
- clampingIsDelayed();
- if (needsScrollAnchoring && !clampingDelayed)
- getScrollableArea()->scrollAnchor()->restore();
-
m_heightAvailableToChildrenChanged = false;
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAnchor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698