Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout. (Closed)
Patch Set: add DCHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 2254b992c0355836176f687ca67616b69d50d73a..d58707f1d1f56e8980243862172570da04a694c5 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -728,6 +728,8 @@ class CORE_EXPORT FrameView final
ScrollAnchor* scrollAnchor() override { return &m_scrollAnchor; }
void clearScrollAnchor();
bool shouldPerformScrollAnchoring() const override;
+ void enqueueScrollAnchoringAdjustment(ScrollableArea*);
+ void performScrollAnchoringAdjustments();
// For PaintInvalidator temporarily. TODO(wangxianzhu): Move into
// PaintInvalidator.
@@ -1076,6 +1078,9 @@ class CORE_EXPORT FrameView final
DocumentLifecycle::LifecycleState m_currentUpdateLifecyclePhasesTargetState;
ScrollAnchor m_scrollAnchor;
+ using AnchoringAdjustmentQueue =
+ HeapLinkedHashSet<WeakMember<ScrollableArea>>;
+ AnchoringAdjustmentQueue m_anchoringAdjustmentQueue;
// ScrollbarManager holds the Scrollbar instances.
ScrollbarManager m_scrollbarManager;
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698