Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2404313002: Remove MessageLoop::current() from url_request.cc. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::current() from url_request.cc. Whenever possible, use ThreadTaskRunnerHandle::Get() instead of MessageLoop::current(). ThreadTaskRunnerHandle::Get() works within TaskScheduler while MessageLoop::current() doesn't. Good reasons to use MessageLoop::current(): - Add destruction, nesting or task observers. - Run nested loops. Bad reasons to use MessageLoop::current(): - Post tasks. Use ThreadTaskRunnerHandle::Get() instead. - Watch a file descriptor. Use FileDescriptorWatcher instead. - Verify that it is possible to post tasks to the current thread. Use ThreadTaskRunnerHandle::IsSet() instead. - Verify that code runs on a specific thread. Use SingleThreadTaskRunner::BelongsToCurrentThread() instead. BUG=650723 Committed: https://crrev.com/1c6a29c14bcff7c8a8d2e6178ea684d50d82558b Cr-Commit-Position: refs/heads/master@{#425151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/url_request/url_request.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-11 17:12:20 UTC) #4
gavinp
lgtm
4 years, 2 months ago (2016-10-13 20:10:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404313002/1
4 years, 2 months ago (2016-10-13 20:10:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 21:04:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 21:06:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c6a29c14bcff7c8a8d2e6178ea684d50d82558b
Cr-Commit-Position: refs/heads/master@{#425151}

Powered by Google App Engine
This is Rietveld 408576698