Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: BUILD.gn

Issue 2404283002: [gn] Add back two warnings V8 uses with gyp (Closed)
Patch Set: [gn] Add back two warnings V8 uses with gyp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 37d45d650a903ebb42518c6a7090c7a047bd1c93..ccecdb6deefa788bea4ddddaa5d8a331dc32053a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -371,6 +371,18 @@ config("toolchain") {
"-fno-inline",
]
}
+
+ if (is_clang) {
+ cflags += [
+ # TODO(hans): Remove once http://crbug.com/428099 is resolved.
+ "-Winconsistent-missing-override",
Michael Achenbach 2016/10/11 12:55:35 I hope this actually switches it on. The gn defaul
Clemens Hammacher 2016/10/11 13:00:26 A local test confirms that it should be switched o
Nico 2016/10/11 13:39:37 This works by luck I think. The usual way is to pu
Michael Achenbach 2016/10/11 13:54:31 This is a config.
+ ]
+
+ if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" ||
+ v8_current_cpu == "mips64el") {
+ cflags += [ "-Wshorten-64-to-32" ]
+ }
+ }
}
###############################################################################
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698