Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/android/BUILD.gn

Issue 2404253003: Reland #2 of Fix monochrome not booting issue (Closed)
Patch Set: Use ui::SetLocalePaksStoredInApk(true) in monochrome entry point Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 475fea4c4acf7c98e0576566bc6d6ee810d7cecd..cd68289c8bd6425fcd7182858528bc85af50d6f7 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -67,24 +67,12 @@ jinja_template("chrome_sync_shell_android_manifest") {
]
}
-locale_pak_resources("chrome_locale_paks") {
- sources = []
- foreach(_locale, locales - android_chrome_omitted_locales) {
- sources += [ "$root_out_dir/locales/$_locale.pak" ]
- }
-
- deps = [
- "//chrome:packed_resources",
- ]
-}
-
android_resources("chrome_java_resources") {
resource_dirs = [
"java/res",
"//chrome/android/java/res_chromium",
]
deps = [
- ":chrome_locale_paks",
":chrome_strings_grd",
"//chrome/app:java_strings_grd",
"//components/autofill/android:autofill_java_resources",
@@ -470,14 +458,6 @@ android_resources("chrome_public_apk_resources") {
]
}
-# TODO(agrieve): Delete once downstream no longer references this target.
-java_group("chrome_public_apk_assets") {
- deps = [
- ":chrome_public_non_pak_assets",
- ":chrome_public_pak_assets",
- ]
-}
-
java_group("chrome_public_non_pak_assets") {
deps = [
"//chrome/android/webapk/libs/runtime_library:runtime_library_assets",
@@ -494,6 +474,7 @@ android_assets("chrome_public_pak_assets") {
disable_compression = true
deps = [
+ ":chrome_public_locale_pak_assets",
"//chrome:packed_resources",
"//chrome/android/webapk/libs/runtime_library:runtime_library_assets",
"//third_party/icu:icu_assets",
@@ -501,6 +482,19 @@ android_assets("chrome_public_pak_assets") {
]
}
+# This target is separate from chrome_public_pak_assets because it does not
+# disable compression.
+android_assets("chrome_public_locale_pak_assets") {
+ sources = []
+ foreach(_locale, locales - android_chrome_omitted_locales) {
+ sources += [ "$root_out_dir/locales/$_locale.pak" ]
+ }
+
+ deps = [
+ "//chrome:packed_resources",
+ ]
+}
+
jinja_template_resources("chrome_public_apk_template_resources") {
resources = [
"java/res_template/xml/chromebackupscheme.xml",
@@ -577,11 +571,15 @@ if (current_toolchain == default_toolchain) {
}
}
- locale_pak_resources("monochrome_locale_paks") {
- sources = []
+ android_assets("monochrome_pak_assets") {
+ sources = [
+ "$target_gen_dir/monochrome_paks/chrome_100_percent.pak",
+ "$target_gen_dir/monochrome_paks/resources.pak",
+ ]
foreach(_locale, locales) {
sources += [ "$target_gen_dir/monochrome_paks/locales/$_locale.pak" ]
}
+ disable_compression = true
deps = [
":monochrome_paks",
@@ -589,17 +587,6 @@ if (current_toolchain == default_toolchain) {
}
} # current_toolchain == host_toolchain
-android_assets("monochrome_pak_assets") {
- sources = [
- "$target_gen_dir/monochrome_paks/chrome_100_percent.pak",
- "$target_gen_dir/monochrome_paks/resources.pak",
- ]
- deps = [
- ":monochrome_paks",
- ]
- disable_compression = true
-}
-
#
# Only 32-bit //chrome/android/monochrome is needed, beside
# being built with 32-bit default toolchain, it is also built
@@ -655,11 +642,11 @@ template("chrome_public_apk_tmpl_shared") {
forward_variables_from(invoker, "*")
native_lib_version_rule = "//build/util:chrome_version_json"
-
deps += [
":chrome_java",
- ":chrome_public_apk_assets",
":chrome_public_apk_resources",
+ ":chrome_public_non_pak_assets",
+ ":chrome_public_pak_assets",
"//base:base_java",
]
}

Powered by Google App Engine
This is Rietveld 408576698