Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: src/wasm/wasm-js.cc

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Address titzer's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-js.cc
diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc
index 57ee2654f9981e96d4b9a513d09689f5c60f590d..36f286f73cffcd58a940d74e7d06442ed8fe1f92 100644
--- a/src/wasm/wasm-js.cc
+++ b/src/wasm/wasm-js.cc
@@ -134,16 +134,16 @@ void VerifyFunction(const v8::FunctionCallbackInfo<v8::Value>& args) {
i::MaybeHandle<i::JSObject> InstantiateModule(
const v8::FunctionCallbackInfo<v8::Value>& args, const byte* start,
- const byte* end, ErrorThrower* thrower,
- internal::wasm::ModuleOrigin origin = i::wasm::kWasmOrigin) {
+ const byte* end, ErrorThrower* thrower) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
// Decode but avoid a redundant pass over function bodies for verification.
// Verification will happen during compilation.
i::Zone zone(isolate->allocator());
i::MaybeHandle<i::JSObject> module_object =
- i::wasm::CreateModuleObjectFromBytes(isolate, start, end, thrower,
- origin);
+ i::wasm::CreateModuleObjectFromBytes(
+ isolate, start, end, thrower, i::wasm::kWasmOrigin,
+ i::Handle<i::Script>::null(), nullptr, nullptr);
i::MaybeHandle<i::JSObject> object;
if (!module_object.is_null()) {
// Success. Instantiate the module and return the object.
@@ -195,8 +195,8 @@ static i::MaybeHandle<i::JSObject> CreateModuleObject(
DCHECK(source->IsArrayBuffer() || source->IsTypedArray());
return i::wasm::CreateModuleObjectFromBytes(
- i_isolate, buffer.start, buffer.end, thrower,
- i::wasm::ModuleOrigin::kWasmOrigin);
+ i_isolate, buffer.start, buffer.end, thrower, i::wasm::kWasmOrigin,
+ i::Handle<i::Script>::null(), nullptr, nullptr);
}
static bool ValidateModule(v8::Isolate* isolate,
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698