test/common/wasm/wasm-module-runner.cc - Issue 2404253002: [wasm] Provide better stack traces for asm.js code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/common/wasm/wasm-module-runner.cc

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)

Patch Set: Pass encoded bytes directly instead of embedding them in the module Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/common/wasm/wasm-module-runner.cc

diff --git a/test/common/wasm/wasm-module-runner.cc b/test/common/wasm/wasm-module-runner.cc

index 15c3ef433f48ff9d1604c058b31a2aa6da0e4d64..588f49b23abe31277f4673f8373df3c7d920cc4d 100644

--- a/test/common/wasm/wasm-module-runner.cc

+++ b/test/common/wasm/wasm-module-runner.cc

@@ -62,7 +62,7 @@ const Handle<JSObject> InstantiateModuleForTesting(Isolate* isolate,

// again through the normal pipeline.

MaybeHandle<JSObject> module_object = CreateModuleObjectFromBytes(

isolate, module->module_start, module->module_end, thrower,

- ModuleOrigin::kWasmOrigin);

+ ModuleOrigin::kWasmOrigin, Handle<Script>::null(), nullptr, nullptr);

if (module_object.is_null()) {

thrower->Error("Module pre-validation failed.");

return Handle<JSObject>::null();