Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: src/isolate.cc

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Pass encoded bytes directly instead of embedding them in the module Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index e8329883f7e6eaf44f04ebbccc137e5f106404e1..a4694d5d9367a3487ad6c5576203c16476f4a723 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -520,9 +520,14 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
DCHECK(wasm::IsWasmObject(*wasm_object) ||
wasm_object->IsUndefined(this));
- elements = FrameArray::AppendWasmFrame(
- elements, wasm_object, wasm_function_index, abstract_code, offset,
- FrameArray::kIsWasmFrame);
+ int flags = FrameArray::kIsWasmFrame;
+ if (wasm::WasmIsAsmJs(*wasm_object, this)) {
+ flags |= FrameArray::kIsAsmWasmFrame;
jgruber 2016/10/11 19:07:40 Would it make sense to mark a frame as either kIsW
Clemens Hammacher 2016/10/12 07:37:18 Done.
+ }
+
+ elements = FrameArray::AppendWasmFrame(elements, wasm_object,
+ wasm_function_index,
+ abstract_code, offset, flags);
} break;
default:
« no previous file with comments | « src/asmjs/asm-wasm-builder.cc ('k') | src/messages.h » ('j') | src/messages.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698