Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/objects-inl.h

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Address titzer's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/wasm/module-decoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2621 matching lines...) Expand 10 before | Expand all | Expand 10 after
2632 set(kFirstIndex + frame_ix * kElementsPerFrame + k##name##Offset, value); \ 2632 set(kFirstIndex + frame_ix * kElementsPerFrame + k##name##Offset, value); \
2633 } 2633 }
2634 FRAME_ARRAY_FIELD_LIST(DEFINE_FRAME_ARRAY_ACCESSORS) 2634 FRAME_ARRAY_FIELD_LIST(DEFINE_FRAME_ARRAY_ACCESSORS)
2635 #undef DEFINE_FRAME_ARRAY_ACCESSORS 2635 #undef DEFINE_FRAME_ARRAY_ACCESSORS
2636 2636
2637 bool FrameArray::IsWasmFrame(int frame_ix) const { 2637 bool FrameArray::IsWasmFrame(int frame_ix) const {
2638 const int flags = Flags(frame_ix)->value(); 2638 const int flags = Flags(frame_ix)->value();
2639 return (flags & kIsWasmFrame) != 0; 2639 return (flags & kIsWasmFrame) != 0;
2640 } 2640 }
2641 2641
2642 bool FrameArray::IsAsmJsWasmFrame(int frame_ix) const {
2643 const int flags = Flags(frame_ix)->value();
2644 return (flags & kIsAsmJsWasmFrame) != 0;
2645 }
2646
2642 int FrameArray::FrameCount() const { 2647 int FrameArray::FrameCount() const {
2643 const int frame_count = Smi::cast(get(kFrameCountIndex))->value(); 2648 const int frame_count = Smi::cast(get(kFrameCountIndex))->value();
2644 DCHECK_LE(0, frame_count); 2649 DCHECK_LE(0, frame_count);
2645 return frame_count; 2650 return frame_count;
2646 } 2651 }
2647 2652
2648 bool DescriptorArray::IsEmpty() { 2653 bool DescriptorArray::IsEmpty() {
2649 DCHECK(length() >= kFirstIndex || 2654 DCHECK(length() >= kFirstIndex ||
2650 this == GetHeap()->empty_descriptor_array()); 2655 this == GetHeap()->empty_descriptor_array());
2651 return length() < kFirstIndex; 2656 return length() < kFirstIndex;
(...skipping 5673 matching lines...) Expand 10 before | Expand all | Expand 10 after
8325 #undef WRITE_INT64_FIELD 8330 #undef WRITE_INT64_FIELD
8326 #undef READ_BYTE_FIELD 8331 #undef READ_BYTE_FIELD
8327 #undef WRITE_BYTE_FIELD 8332 #undef WRITE_BYTE_FIELD
8328 #undef NOBARRIER_READ_BYTE_FIELD 8333 #undef NOBARRIER_READ_BYTE_FIELD
8329 #undef NOBARRIER_WRITE_BYTE_FIELD 8334 #undef NOBARRIER_WRITE_BYTE_FIELD
8330 8335
8331 } // namespace internal 8336 } // namespace internal
8332 } // namespace v8 8337 } // namespace v8
8333 8338
8334 #endif // V8_OBJECTS_INL_H_ 8339 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/wasm/module-decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698