Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2404243002: [modules] Move runtime functions into new file (runtime-module.cc). (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Move runtime functions into new file (runtime-module.cc). R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/4ff5c2a72fefb7d8d645672df46d3b5802902129 Cr-Commit-Position: refs/heads/master@{#40184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -34 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A src/runtime/runtime-module.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
4 years, 2 months ago (2016-10-11 09:12:34 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-10-11 15:56:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404243002/1
4 years, 2 months ago (2016-10-11 15:57:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/14304)
4 years, 2 months ago (2016-10-11 16:09:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404243002/1
4 years, 2 months ago (2016-10-11 17:09:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:32:29 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:32:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff5c2a72fefb7d8d645672df46d3b5802902129
Cr-Commit-Position: refs/heads/master@{#40184}

Powered by Google App Engine
This is Rietveld 408576698