Aborts all pending fetch event callbacks in ServiceWorkerContextClient::willDestroyWorkerContext.

Aborts all pending fetch event callbacks in ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event callbacks before the destruction.

BUG=649558
Committed: https://crrev.com/e9dbf555b882b7247e5029aee2ae070c026bd2f1
Cr-Commit-Position: refs/heads/master@{#424672}

[horo, 2016-10-11 13:20:28]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 13:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 14:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 14:57:22]

Dry run: This issue passed the CQ dry run.

[horo, 2016-10-12 02:20:56]

Description was changed from

==========
Aborts the all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

BUG=
==========

to

==========
Aborts all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event
callbacks before the destruction.

BUG=649558
==========

[horo, 2016-10-12 02:21:35]

horo@chromium.org changed reviewers:
+ shimazu@chromium.org

[horo, 2016-10-12 02:21:35]

shimazu@
Could you please review this?

[horo, 2016-10-12 02:21:40]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 02:22:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shimazu, 2016-10-12 02:30:12]

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js
(right):

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:1:
self.addEventListener('fetch', function(evt) {
nit: How about 'evt => {...}' ?

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:2:
evt.respondWith(new Response(''));
I think this is not necessary.

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:3:
evt.waitUntil(new Promise(function() {}));
Could you add a short comment why it's not resolved/rejected?

[horo, 2016-10-12 03:12:19]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 03:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-12 03:13:04]

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js
(right):

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:1:
self.addEventListener('fetch', function(evt) {
On 2016/10/12 02:30:12, shimazu wrote:
> nit: How about 'evt => {...}' ?

Done.

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:2:
evt.respondWith(new Response(''));
On 2016/10/12 02:30:12, shimazu wrote:
> I think this is not necessary.

We need it, to resolve with_iframe().

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:3:
evt.waitUntil(new Promise(function() {}));
On 2016/10/12 02:30:12, shimazu wrote:
> Could you add a short comment why it's not resolved/rejected?

Added.

[shimazu, 2016-10-12 03:49:25]

lgtm!

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js
(right):

https://codereview.chromium.org/2404233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/stop-worker-with-pending-fetch.js:2:
evt.respondWith(new Response(''));
On 2016/10/12 03:13:04, horo wrote:
> On 2016/10/12 02:30:12, shimazu wrote:
> > I think this is not necessary.
> 
> We need it, to resolve with_iframe().

I didn't know that, thanks!

[horo, 2016-10-12 03:57:16]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-10-12 03:57:17]

The CQ bit was checked by horo@chromium.org

[horo, 2016-10-12 03:57:17]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-10-12 03:57:22]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-12 03:57:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:00:51]

Description was changed from

==========
Aborts all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event
callbacks before the destruction.

BUG=649558
==========

to

==========
Aborts all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event
callbacks before the destruction.

BUG=649558
==========

[commit-bot: I haz the power, 2016-10-12 05:00:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-12 05:02:18]

Description was changed from

==========
Aborts all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event
callbacks before the destruction.

BUG=649558
==========

to

==========
Aborts all pending fetch event callbacks in
ServiceWorkerContextClient::willDestroyWorkerContext.

Same as https://crrev.com/2405163002/, we have to execute the fetch event
callbacks before the destruction.

BUG=649558

Committed: https://crrev.com/e9dbf555b882b7247e5029aee2ae070c026bd2f1
Cr-Commit-Position: refs/heads/master@{#424672}
==========

[commit-bot: I haz the power, 2016-10-12 05:02:19]

Patchset 5 (id:??) landed as
https://crrev.com/e9dbf555b882b7247e5029aee2ae070c026bd2f1
Cr-Commit-Position: refs/heads/master@{#424672}