[CSS Shapes] Can't select content within the area of the floating box when clip-path is applied

Source/core/rendering/RenderBlock.cpp

Index: Source/core/rendering/RenderBlock.cpp
diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp
index 87e0beedb05291c078147aa406c6a8ed9d16d69e..e3125c789cad4f3eca557ccd50b0ac5d1e98a9b2 100644
--- a/Source/core/rendering/RenderBlock.cpp
+++ b/Source/core/rendering/RenderBlock.cpp
@@ -2765,6 +2765,16 @@ bool RenderBlock::nodeAtPoint(const HitTestRequest& request, HitTestResult& resu
            return true;
     }
 
+    if (style()->clipPath()) {
+        // FIXME: handle REFERENCE

[krit, 2014/04/16 18:51:08]

I would do a switch here to make sure you cover all the things.

+        if (style()->clipPath()->type() == ClipPathOperation::SHAPE) {
+            ShapeClipPathOperation* clipPath = toShapeClipPathOperation(style()->clipPath());
+            // FIXME: handle marginBox etc.
+            if (!clipPath->path(borderBoxRect()).contains(locationInContainer.point() - localOffset, clipPath->windRule()))

[krit, 2014/04/16 18:51:08]

Not sure if that is a win here. What about checking if the point is in the
bounding box first? It might make it slower though since we do not need the
bounding box anywhere else.

Also, checking path is one way, for things like circle or ellipse and maybe even
rect you don't want that and it is faster to do it yourself. Not sure how Skia
handles these cases though.

+                return false;
+        }
+    }
+
     // If we have clipping, then we can't have any spillout.
     bool useOverflowClip = hasOverflowClip() && !hasSelfPaintingLayer();
     bool useClip = (hasControlClip() || useOverflowClip);