Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2404223003:
Modify Blink.Canvas.toDataURL UMA performance metrics (Closed)
|
Created:
4 years, 2 months ago by xlai (Olivia) Modified:
4 years, 2 months ago CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, asvitkine+watch_chromium.org, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionModify Blink.Canvas.toDataURL UMA performance metrics
Previously the Blink.Canvas.toDataURL performance metrics is
collecting PNG encoding data in many separate buckets,
including Blink.Canvas.toDataURL.PNG and all the other
unsupported image types. This is because the previous code
overlooks that toEncodingMimeType function is converting all
unsupported types to "image/png".
I corrected this by putting the UMA data tracking code after
the toEncodingMimeType function, and also remove those buckets
for unsupported image types.
BUG=612585
Committed: https://crrev.com/353e43e71ccee2891f9c7484f847eafff2c1d55b
Cr-Commit-Position: refs/heads/master@{#425074}
Patch Set 1 #Patch Set 2 : Instead of remove, modify #
Total comments: 2
Patch Set 3 : obsolete #
Messages
Total messages: 22 (11 generated)
xlai@chromium.org changed reviewers: + junov@chromium.org, jwd@chromium.org
lgtm
Description was changed from ========== Remove duplicate Canvas UMA performance metrics The user data tracked by Blink.Canvas.ToDataURL metric is actually the partial user data trakced by Canvas.RequestedImageMimeTypes_toDataURL. BUG=612585 ========== to ========== Remove duplicate Canvas UMA performance metrics [Not ready yet] BUG=612585 ==========
xlai@chromium.org changed reviewers: + xidachen@chromium.org
Description was changed from ========== Remove duplicate Canvas UMA performance metrics [Not ready yet] BUG=612585 ========== to ========== Remove duplicate Canvas UMA performance metrics [not ready yet] [Not ready yet] BUG=612585 ==========
Description was changed from ========== Remove duplicate Canvas UMA performance metrics [not ready yet] [Not ready yet] BUG=612585 ========== to ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingType function, and also remove those buckets for unsupported image types. BUG=612585 ==========
Title and content changed.
Description was changed from ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingType function, and also remove those buckets for unsupported image types. BUG=612585 ========== to ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingMimeType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingMimeType function, and also remove those buckets for unsupported image types. BUG=612585 ==========
On 2016/10/12 15:08:01, xlai (Olivia) wrote: > Title and content changed. Yep, this change makes perfect sense. lgtm on core/.
https://codereview.chromium.org/2404223003/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2404223003/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:102562: - <suffix name="Unknown"/> Please mark these as obsolete rather than deleting them.
Patchset #3 (id:40001) has been deleted
https://codereview.chromium.org/2404223003/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2404223003/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:102562: - <suffix name="Unknown"/> On 2016/10/12 19:01:30, jwd wrote: > Please mark these as obsolete rather than deleting them. Done.
lgtm
lgtm
The CQ bit was checked by xlai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org Link to the patchset: https://codereview.chromium.org/2404223003/#ps60001 (title: "obsolete")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingMimeType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingMimeType function, and also remove those buckets for unsupported image types. BUG=612585 ========== to ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingMimeType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingMimeType function, and also remove those buckets for unsupported image types. BUG=612585 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingMimeType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingMimeType function, and also remove those buckets for unsupported image types. BUG=612585 ========== to ========== Modify Blink.Canvas.toDataURL UMA performance metrics Previously the Blink.Canvas.toDataURL performance metrics is collecting PNG encoding data in many separate buckets, including Blink.Canvas.toDataURL.PNG and all the other unsupported image types. This is because the previous code overlooks that toEncodingMimeType function is converting all unsupported types to "image/png". I corrected this by putting the UMA data tracking code after the toEncodingMimeType function, and also remove those buckets for unsupported image types. BUG=612585 Committed: https://crrev.com/353e43e71ccee2891f9c7484f847eafff2c1d55b Cr-Commit-Position: refs/heads/master@{#425074} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/353e43e71ccee2891f9c7484f847eafff2c1d55b Cr-Commit-Position: refs/heads/master@{#425074} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
