Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2404223002: Revert of [regexp] Port test, match, and search (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
Yang, jgruber
CC:
v8-reviews_googlegroups.com, rmcilroy, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port test, match, and search (patchset #4 id:60001 of https://codereview.chromium.org/2394713003/ ) Reason for revert: Seems to have made regexp-property-lu-ui more than twice as slow in gc stress (and flaky slow): https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/6309 Original issue's description: > [regexp] Port test, match, and search > > This CL ports RegExp.prototype.test, RegExp.prototype.match > and RegExp.prototype.search to C++. > > Performance regressions are expected but should be improved > in an upcoming CL. > > BUG=v8:5339 > > Committed: https://crrev.com/80f3c6ce7702c0cc28388ae4f084c23870a9aa4f > Cr-Commit-Position: refs/heads/master@{#40122} TBR=yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -306 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 3 chunks +2 lines, -261 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M src/js/regexp.js View 4 chunks +68 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [regexp] Port test, match, and search
4 years, 2 months ago (2016-10-11 06:50:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404223002/1
4 years, 2 months ago (2016-10-11 06:50:40 UTC) #3
commit-bot: I haz the power
Failed to apply patch for test/cctest/interpreter/bytecode_expectations/CallRuntime.golden: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-11 06:50:51 UTC) #5
Michael Achenbach
4 years, 2 months ago (2016-10-11 06:53:40 UTC) #6
Closing this in favor of skipping the test.

Powered by Google App Engine
This is Rietveld 408576698