Implement incremental paint property tree rebuilding

third_party/WebKit/Source/core/frame/FrameView.h

 /*
    Copyright (C) 1997 Martin Jones (mjones@kde.org)
              (C) 1998 Waldo Bastian (bastian@kde.org)
              (C) 1998, 1999 Torben Weis (weis@kde.org)
              (C) 1999 Lars Knoll (knoll@kde.org)
              (C) 1999 Antti Koivisto (koivisto@kde.org)
    Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
    reserved.
 
    This library is free software; you can redistribute it and/or
@@ skipping 700 matching lines @@
   // properties are either created by this FrameView or are inherited from
   // an ancestor.
   void setTotalPropertyTreeStateForContents(
       std::unique_ptr<PropertyTreeState> state) {
     m_totalPropertyTreeStateForContents = std::move(state);
   }
   const PropertyTreeState* totalPropertyTreeStateForContents() const {
     return m_totalPropertyTreeStateForContents.get();
   }
 
+  // Paint properties (e.g., m_preTranslation, etc.) are built from the
+  // FrameView's state (e.g., x(), y(), etc.) and need to be invalidated when
+  // these values change (see: PaintPropertyTreeBuilder::updateProperties).
+  // Invalid paint properties will be rebuilt during the next lifecycle update
+  // (see: FrameView::updatePaintProperties).
+  void setPaintPropertiesInvalid() { m_paintPropertiesValid = false; }

[chrishtr, 2016/10/21 22:03:09]

...Invalid is different nomenclature from invalidations on other tree walks for
layout, paint invalidation, etc.
What common naming scheme should we use?

[pdr., 2016/10/26 03:10:48]

I've switched this to the following which is similar to layout and paint
invalidation:
setNeedsPropertyUpdate()
clearNeedsPropertyUpdate()

I've also added comments about how we can expand this in the future. Possibly
something along these lines:
setNeedsLocalPropertyUpdate()
setNeedsSubtreePropertyUpdate()
...etc

+  void setPaintPropertiesValid() {
+    DCHECK_EQ(lifecycle().state(), DocumentLifecycle::InPrePaint);
+    m_paintPropertiesValid = true;
+  }
+  bool paintPropertiesValid() const { return m_paintPropertiesValid; }
+
   // TODO(ojan): Merge this with IntersectionObserver once it lands.
   IntRect computeVisibleArea();
 
   // Viewport size that should be used for viewport units (i.e. 'vh'/'vw').
   FloatSize viewportSizeForViewportUnits() const;
 
   ScrollAnchor* scrollAnchor() override { return &m_scrollAnchor; }
   void clearScrollAnchor();
   bool shouldPerformScrollAnchoring() const override;
 
@@ skipping 321 matching lines @@
   RefPtr<TransformPaintPropertyNode> m_scrollTranslation;
   RefPtr<ScrollPaintPropertyNode> m_scroll;
   // The content clip clips the document (= LayoutView) but not the scrollbars.
   // TODO(trchen): This will not be needed once settings->rootLayerScrolls() is
   // enabled.
   RefPtr<ClipPaintPropertyNode> m_contentClip;
   // The property tree state that should be used for painting contents. These
   // properties are either created by this FrameView or are inherited from
   // an ancestor.
   std::unique_ptr<PropertyTreeState> m_totalPropertyTreeStateForContents;
+  // True if the paint properties are up-to-date with the FrameView's state.
+  // See: setPaintPropertiesValid and setPaintPropertiesInvalid.
+  bool m_paintPropertiesValid = false;
 
   // This is set on the local root frame view only.
   DocumentLifecycle::LifecycleState m_currentUpdateLifecyclePhasesTargetState;
 
   ScrollAnchor m_scrollAnchor;
 
   bool m_needsScrollbarsUpdate;
   bool m_suppressAdjustViewSize;
   bool m_allowsLayoutInvalidationAfterLayoutClean;
 
@@ skipping 41 matching lines @@
                   widget.isFrameView());
 DEFINE_TYPE_CASTS(FrameView,
                   ScrollableArea,
                   scrollableArea,
                   scrollableArea->isFrameView(),
                   scrollableArea.isFrameView());
 
 }  // namespace blink
 
 #endif  // FrameView_h