Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2404213004: Implement incremental paint property tree rebuilding (Closed)
Patch Set: Fix bug in how svg local to border box was updated, no longer crash in tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 3359 matching lines...) Expand 10 before | Expand all | Expand 10 after
3370 } 3370 }
3371 3371
3372 void FrameView::frameRectsChanged() { 3372 void FrameView::frameRectsChanged() {
3373 TRACE_EVENT0("blink", "FrameView::frameRectsChanged"); 3373 TRACE_EVENT0("blink", "FrameView::frameRectsChanged");
3374 if (layoutSizeFixedToFrameSize()) 3374 if (layoutSizeFixedToFrameSize())
3375 setLayoutSizeInternal(frameRect().size()); 3375 setLayoutSizeInternal(frameRect().size());
3376 3376
3377 setNeedsUpdateViewportIntersection(); 3377 setNeedsUpdateViewportIntersection();
3378 for (const auto& child : m_children) 3378 for (const auto& child : m_children)
3379 child->frameRectsChanged(); 3379 child->frameRectsChanged();
3380
3381 setPaintPropertiesInvalid();
chrishtr 2016/10/21 22:03:09 Add a brief comment explaining which property tree
pdr. 2016/10/26 03:10:48 Done
3380 } 3382 }
3381 3383
3382 void FrameView::setLayoutSizeInternal(const IntSize& size) { 3384 void FrameView::setLayoutSizeInternal(const IntSize& size) {
3383 if (m_layoutSize == size) 3385 if (m_layoutSize == size)
3384 return; 3386 return;
3385 3387
3386 m_layoutSize = size; 3388 m_layoutSize = size;
3387 contentsResized(); 3389 contentsResized();
3388 } 3390 }
3389 3391
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
3608 } 3610 }
3609 3611
3610 if (scrollType != AnchoringScroll) 3612 if (scrollType != AnchoringScroll)
3611 clearScrollAnchor(); 3613 clearScrollAnchor();
3612 } 3614 }
3613 3615
3614 void FrameView::didChangeScrollOffset() { 3616 void FrameView::didChangeScrollOffset() {
3615 frame().loader().client()->didChangeScrollOffset(); 3617 frame().loader().client()->didChangeScrollOffset();
3616 if (frame().isMainFrame()) 3618 if (frame().isMainFrame())
3617 frame().host()->chromeClient().mainFrameScrollOffsetChanged(); 3619 frame().host()->chromeClient().mainFrameScrollOffsetChanged();
3620 setPaintPropertiesInvalid();
chrishtr 2016/10/21 22:03:09 Add a brief comment explaining which property tree
pdr. 2016/10/26 03:10:48 Done. I tightened these invalidations up a bit as
3618 } 3621 }
3619 3622
3620 void FrameView::clearScrollAnchor() { 3623 void FrameView::clearScrollAnchor() {
3621 if (!RuntimeEnabledFeatures::scrollAnchoringEnabled()) 3624 if (!RuntimeEnabledFeatures::scrollAnchoringEnabled())
3622 return; 3625 return;
3623 m_scrollAnchor.clear(); 3626 m_scrollAnchor.clear();
3624 } 3627 }
3625 3628
3626 bool FrameView::hasOverlayScrollbars() const { 3629 bool FrameView::hasOverlayScrollbars() const {
3627 return (m_horizontalScrollbar && 3630 return (m_horizontalScrollbar &&
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
4489 DCHECK(m_frame->isMainFrame()); 4492 DCHECK(m_frame->isMainFrame());
4490 return m_initialViewportSize.width(); 4493 return m_initialViewportSize.width();
4491 } 4494 }
4492 4495
4493 int FrameView::initialViewportHeight() const { 4496 int FrameView::initialViewportHeight() const {
4494 DCHECK(m_frame->isMainFrame()); 4497 DCHECK(m_frame->isMainFrame());
4495 return m_initialViewportSize.height(); 4498 return m_initialViewportSize.height();
4496 } 4499 }
4497 4500
4498 } // namespace blink 4501 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698