CSS will-change: Mentioning transform properties gives containing block

CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
Committed: https://crrev.com/96cb4a9eeec773741f99097ee395f3098ead57a6
Cr-Commit-Position: refs/heads/master@{#429832}

[Eric Willigers, 2016-10-12 02:54:10]

Description was changed from

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
==========

to

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
==========

[Eric Willigers, 2016-10-12 02:54:10]

ericwilligers@chromium.org changed reviewers:
+ ajuma@chromium.org

[Eric Willigers, 2016-10-14 00:31:54]

I haven't received any feedback from the CSS Working Group on
https://github.com/w3c/csswg-drafts/pull/587

[ajuma, 2016-10-14 14:18:04]

On 2016/10/14 00:31:54, Eric Willigers wrote:
> I haven't received any feedback from the CSS Working Group on
> https://github.com/w3c/csswg-drafts/pull/587

Non-owner lgtm

Given that we already create a containing block for non-initial values of these
properties, I don't think we need to wait for the transforms spec to change
before landing this.

[Eric Willigers, 2016-10-15 21:57:00]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-10-15 21:57:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 22:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 22:06:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2016-10-21 04:14:46]

ericwilligers@chromium.org changed reviewers:
+ pdr@chromium.org

[Eric Willigers, 2016-11-03 08:25:21]

Added pdr for OWNER review.

[pdr., 2016-11-03 20:02:32]

pdr@chromium.org changed reviewers:
+ trchen@chromium.org

[pdr., 2016-11-03 20:02:59]

LGTM here too.

@Tien-Ren, just added you to the review as a sanity check. I think this is good
to go.

[trchen, 2016-11-03 21:21:27]

lgtm

Thanks for the clean up! <3

[Eric Willigers, 2016-11-03 21:22:19]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:22:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:53:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-11-04 08:29:40]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:30:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 08:35:36]

Description was changed from

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
==========

to

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
==========

[commit-bot: I haz the power, 2016-11-04 08:35:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 08:40:06]

Description was changed from

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607
==========

to

==========
CSS will-change: Mentioning transform properties gives containing block

We already create a containing block if 'perspective' or one of the
indepedent transform properties is not their initial value.

Now we also create a containing block if these properties are mentioned
in 'will-change'.
https://drafts.csswg.org/css-will-change/#will-change
"If any non-initial value of a property would cause the element to
generate a containing block for fixed positioned elements, specifying
that property in will-change must cause the element to generate a
containing block for fixed positioned elements."

BUG=650607

Committed: https://crrev.com/96cb4a9eeec773741f99097ee395f3098ead57a6
Cr-Commit-Position: refs/heads/master@{#429832}
==========

[commit-bot: I haz the power, 2016-11-04 08:40:07]

Patchset 1 (id:??) landed as
https://crrev.com/96cb4a9eeec773741f99097ee395f3098ead57a6
Cr-Commit-Position: refs/heads/master@{#429832}