Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2404193004: Revert of Use non-deprecated screen update callbacks. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use non-deprecated screen update callbacks. (patchset #9 id:160001 of https://codereview.chromium.org/2391743004/ ) Reason for revert: unit test coverage is poor. Local testing shows that this code doesn't work. Reverting. Original issue's description: > Use non-deprecated screen update callbacks. > > CGRegisterScreenRefreshCallback (and similar) have been replaced by > CGDisplayStream. > > Most of the structure is pretty comparable. The main difference is that a > CGDisplayStream needs to be destroyed asynchronously, potentially after > ScreenCapturerMac has been destroyed. This CL creates a self-owned > DisplayStreamManager which will destroy itself once all streams have been > destroyed. > > BUG=webrtc:6029 > > Committed: https://crrev.com/440b4be4b7609680e39898730f76ce2ec5ab3253 > Cr-Commit-Position: refs/heads/master@{#14590} TBR=eugenebut@chromium.org,sergeyu@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -156 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 8 chunks +48 lines, -156 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
Created Revert of Use non-deprecated screen update callbacks.
4 years, 2 months ago (2016-10-12 01:11:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2404193004/1
4 years, 2 months ago (2016-10-12 01:11:43 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-12 01:11:44 UTC) #5
erikchen
4 years, 2 months ago (2016-10-12 18:28:50 UTC) #6
On 2016/10/12 01:11:44, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-webrtc-committers".
> Note that this has nothing to do with OWNERS files.

apparently I can't revert my own CLs....well, I already have a fix up:
https://codereview.chromium.org/2417603002/, so closing this out.

Powered by Google App Engine
This is Rietveld 408576698