Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2404183002: Prune deprecated functions from InsertTextCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from InsertTextCommand BUG=647219, 648949, 651373 Committed: https://crrev.com/498e9e19dffeb563c02167e40da7a4424eaba02e Cr-Commit-Position: refs/heads/master@{#424392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 6 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-11 06:19:10 UTC) #6
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-11 08:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404183002/1
4 years, 2 months ago (2016-10-11 08:26:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 08:32:30 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:34:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/498e9e19dffeb563c02167e40da7a4424eaba02e
Cr-Commit-Position: refs/heads/master@{#424392}

Powered by Google App Engine
This is Rietveld 408576698