Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2404163004: DBC: Add Smi fastpath to AssertAssignable (Closed)
Patch Set: Remove spurious comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 0de0709c701fd6c02413f7f53f3dea055dde6676..e574fd108fe8e27ccea72ed3ddba9b7171a5f523 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -526,10 +526,11 @@ namespace dart {
// (A = 1) a subtype of SP[-1] using SubtypeTestCache SP[0], with result
// placed at top of stack.
//
-// - AssertAssignable D
+// - AssertAssignable A, D
//
// Assert that SP[-3] is assignable to variable named SP[0] of type
// SP[-1] with type arguments SP[-2] using SubtypeTestCache PP[D].
+// If A is 1, then the instance may be a Smi.
//
// - BadTypeError
//
@@ -797,7 +798,7 @@ namespace dart {
V(InstantiateTypeArgumentsTOS, A_D, num, lit, ___) \
V(InstanceOf, A, num, ___, ___) \
V(BadTypeError, 0, ___, ___, ___) \
- V(AssertAssignable, D, num, lit, ___) \
+ V(AssertAssignable, A_D, num, lit, ___) \
V(AssertBoolean, A, num, ___, ___) \
V(TestSmi, A_D, reg, reg, ___) \
V(TestCids, A_D, reg, num, ___) \
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698