Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2404163004: DBC: Add Smi fastpath to AssertAssignable (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Add Smi fastpath to AssertAssignable Flutter layout benchmark 14k us -> 10k us. ~30% improvement in checked mode. There still appear to be a lot of checks that should be hitting the cache, so there may be other fast-paths needed as well. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/775fce18d5e6acfe461c214fba2369806722dbe1

Patch Set 1 #

Patch Set 2 : Remove spurious comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M runtime/vm/constants_dbc.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +14 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 2 months ago (2016-10-11 20:47:20 UTC) #3
Florian Schneider
lgtm
4 years, 2 months ago (2016-10-11 21:11:41 UTC) #4
zra
4 years, 2 months ago (2016-10-11 21:25:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
775fce18d5e6acfe461c214fba2369806722dbe1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698